Ticket #83 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

recipe editor could use some context clues

Reported by: erik Owned by: ccowart
Priority: major Milestone: confman-1.9.3
Component: confman Version: 1.9.2b
Keywords: recipe create Cc:

Description

Hi

I'm setting up confman on a new host. I created a module for the
host (called new-reccev1cp). I then tried to create a recipe for the
host, using confman recipe create new-reccev1cp. When running this
command, I repeatedly get the following error.

confman[67605]: erik: Error: recipe references non-existent module Create

Erik

Change History

comment:1 Changed 2 years ago by erik

  • Status changed from new to closed
  • Resolution set to invalid

Never mind; I mistook the step where I was to edit the recipe as the svn commit log edit step.

comment:2 Changed 2 years ago by ccowart

  • Status changed from closed to reopened
  • Resolution invalid deleted
  • Summary changed from unable to create new recipe for a host to recipe editor could use some context clues

I think it's worth improving the user experience here to make it less
confusing.

We could have the recipe editor open on a template with some instructions.

Maybe just:

# Recipe: <NAME>
# $Id$
#
# Please enter the modules for this recipe, one per line, below

comment:3 Changed 2 years ago by ccowart

  • Owner changed from confman-developers@… to ccowart
  • Status changed from reopened to accepted

comment:4 Changed 2 years ago by ccowart

In [462] Reworked the way in which confman handles opening an EDITOR for
recipe editing and log message capturing.

This implements a reasonable template for recipe files providing better
context clues to the user. See #83.

This also allows recipes to be created non-interactively. After adding
the -R flag to confman recipe create, it became obvious that unless
the svn logs could also be captured with something like -m or -F
(similar to actual svn client behavior), that things wouldn't be totally
non-interactive. A lot of rewriting of log handling has happened, touching
both the install and commit functions in addition to the recipe editor.
See #84.

Due to the large extent of these changes, let's make sure it gets a good
round of testing in several environments before we clear it to be merged
into the 1.9 branch.

The referenced tickets will remain open until the merge has happened.

comment:5 Changed 2 years ago by ccowart

(In [464]) I've significantly improved the new log message handling features.

The -m/-F now are expected in the more intuitive placement of after the
command they modify (just like svn).

They were also adopted to the recipe create, edit, and remove commands with
their new placement.

See #83, #84

comment:6 Changed 2 years ago by ccowart

  • Status changed from accepted to needsmerge

comment:7 Changed 2 years ago by ccowart

  • Status changed from needsmerge to closed
  • Resolution set to fixed

(In [481]) Merging improved recipe creation and editing from trunk.

Resolves #83, #84

Note: See TracTickets for help on using tickets.