Ticket #42 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

confman does not correctly import an empty directory

Reported by: blee Owned by: confman-developers@…
Priority: major Milestone: confman-2.0
Component: confman Version: 1.9.0b
Keywords: Cc:

Description

Reporter: Nat Baldwin <nbaldwin@…>

blee@… ~ $ sudo mkdir /etc/emptydir
blee@… ~ $ confman import supra /etc/emptydir
Who should be the file's owner? [ root ]

Who should be the file's group? [ root ]

What should the file's permissions be? [ 0644 ]
0755
What string starts comment lines? [ # ]
dir
Making directory /etc with root:root, 755
Making directory /etc/emptydir with root:root, 755
/usr/bin/svn mkdir /home/blee/src/conf/supra/etc/emptydir
A /home/blee/src/conf/supra/etc/emptydir
property 'confman:owner' set on '/home/blee/src/conf/supra/etc/emptydir'
property 'confman:group' set on '/home/blee/src/conf/supra/etc/emptydir'
property 'confman:mode' set on '/home/blee/src/conf/supra/etc/emptydir'
property 'confman:comment' set on '/home/blee/src/conf/supra/etc/emptydir'
/etc/emptydir/*
A /home/blee/src/conf/supra/etc/emptydir/*
property 'svn:keywords' set on '/home/blee/src/conf/supra/etc/emptydir/*'
property 'confman:owner' set on '/home/blee/src/conf/supra/etc/emptydir/*'
property 'confman:group' set on '/home/blee/src/conf/supra/etc/emptydir/*'
property 'confman:mode' set on '/home/blee/src/conf/supra/etc/emptydir/*'
property 'confman:comment' set on '/home/blee/src/conf/supra/etc/emptydir/*'
property 'confman:symlink' set on '/home/blee/src/conf/supra/etc/emptydir/*'

Change History

comment:1 Changed 3 years ago by ccowart

  • Status changed from new to closed
  • Resolution set to fixed

(In [386])

  • Fixed glob expansion bug in import that led to not-so-empty empty directories on import (I apologize in advance for having to bring arrays into the mix, but it's the only way to preserve whitespace the right way -- and inevitably, somebody is going to want to manage a file with spaces in the name...).
  • Added some error checking in import which will prevent you from importing into a non-existent module (believe it or not, that was possible until now).

Fixes #42.

Note: See TracTickets for help on using tickets.