Ticket #25 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

confman recipe set overreacts to non-existent recipe

Reported by: ccowart Owned by: confman-developers@…
Priority: minor Milestone: confman-2.0
Component: confman Version: 1.9
Keywords: Cc:

Description 

ccowart magrathea conf $ confman recipe set doomed
confman[18936]: ccowart: Error: recipe doomed does not exist. Create it first!
Please wait until I finish cleaning up after you.
Removing leftover temp files...
Removing any system or working copy locks...
Password:
Sorry, try again.
Password:
Sorry, try again.
Password:
Undoing damage to your working copy...
All clean. Terminating.

Because no repository or system operations have taken place, there is no need to run the full cleanup code in this case.

Change History

comment:1 Changed 3 years ago by ccowart

  • Version set to 1.9

comment:2 Changed 3 years ago by ccowart

  • Status changed from new to closed
  • Resolution set to fixed

(In [387]) Cleaned up exit handling.

  • A new global, WCOPY_DIRTY is set whenever the working copy lock is obtained. This works, because the lock is obtained whenever the working copy is to be modified.
  • The exit trap is now silent (unless debugging output is enabled).
  • The advisories to the user to be patient was attached to a separate trap handler for signals.

Overall, this allows conf_cleanExit to be called from anywhere to take
care of locks and tmpfiles without scaring the user.

Fixes #25

Note: See TracTickets for help on using tickets.